feat: add Grouping/TreeData option to toggleOnNodeTitle#2552
feat: add Grouping/TreeData option to toggleOnNodeTitle#2552ghiscoding merged 9 commits intomasterfrom
toggleOnNodeTitle#2552Conversation
Co-authored-by: Copilot <copilot@github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2552 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 196 196
Lines 24959 24973 +14
Branches 8812 8821 +9
=======================================
+ Hits 24959 24973 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
angular-slickgrid
aurelia-slickgrid
slickgrid-react
slickgrid-vue
@slickgrid-universal/angular-row-detail-plugin
@slickgrid-universal/aurelia-row-detail-plugin
@slickgrid-universal/react-row-detail-plugin
@slickgrid-universal/vue-row-detail-plugin
@slickgrid-universal/binding
@slickgrid-universal/common
@slickgrid-universal/composite-editor-component
@slickgrid-universal/custom-footer-component
@slickgrid-universal/custom-tooltip-plugin
@slickgrid-universal/empty-warning-component
@slickgrid-universal/event-pub-sub
@slickgrid-universal/excel-export
@slickgrid-universal/graphql
@slickgrid-universal/odata
@slickgrid-universal/pagination-component
@slickgrid-universal/pdf-export
@slickgrid-universal/row-detail-view-plugin
@slickgrid-universal/rxjs-observable
@slickgrid-universal/sql
@slickgrid-universal/text-export
@slickgrid-universal/utils
@slickgrid-universal/vanilla-bundle
@slickgrid-universal/vanilla-force-bundle
commit: |
toggleByCellClick optiontoggleByCellClick
toggleByCellClicktoggleOnTitle
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
toggleOnTitletoggleOnNodeTitle
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
|
cc @zewa666 any feedback before I merge this one? |
|
hey there, I remember we had this thingy where a PR would create a demo site built with that commit in a sandbox for testing. Is that still a thing? Things I'd like to test would be:
|
@zewa666 sadly not anymore because Stackblitz is stuck at pnpm 8 and fails for pnpm 9+ (pnpm 11 came out today), which is why I removed the broken button (the other buttons I have in all readmes are ok because I use npm in all demo repos). That's why I added a video above
|
|
the reason was that if I start any of the mentioned actions, as a side effect a toggling could happen |
|
@zewa666 I still don't see how unless you mean that PR #2448 has negative side effect? But my PR is not related to that at all and is also optional so I don't see how that could impact users. However, I did see that inline editor could have been a concern, so I did change PR to avoid conflicting with inline editing and limited my approach to only group/tree title (which I assume is what most users will want and expect, I personally want this and so I'll enable this as a global setting in my project) |
|
🎉 This pull request is included in version 10.6.0 📦 |
add a new option named
toggleByCellClicktoggleOnNodeTitlethat allows clicking on the Tree Data and/or Grouping node title to toggle it. This can be helpful since some user, like me, might find the toggle icon a little too small to click. The new option won't be enabled by default and will keep the same original behavior (not everyone would want this, hence its default disabled state)gridOptions = { treeDataOptions: { toggleOnNodeTitle: true, }}gridOptions = { groupItemMetadataOption: { toggleOnNodeTitle: true, }}TODO
toggleOnNodeTitlesince cell click might interfere with other processes like inline cell editingScreencast_20260427_222730.webm