-
-
Notifications
You must be signed in to change notification settings - Fork 33
Updated UI for netcardmgr #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…click to open a new configuration window, which will be specific to the interface. In the process of building out the Configuration menue.
…add flags to explicitly call certain classes. Fleshed out the configuration window and put in some dummy information as placeholders on the tabs.
…interfaces. Need to build UI for other configureable aspects, then once done with that bind changes made inconfig window to changes made through ifconfig.
… boxes. Need to do more research.
…ave and cancle button, then connect actions to ifconfig calls.
…actions on the UI with methods, most of which will probably be in the netapi file.
…g issues with it detecting DHCP on the wlan0 interface, but will have to fix this later.
…nt settings, but I'm having a hard time updating the window. May need to transform the currentSettings Dict into another class or something along those lines.
ericbsd
approved these changes
May 4, 2020
Member
ericbsd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Peter2121
pushed a commit
to Peter2121/networkmgr
that referenced
this pull request
May 30, 2020
Updated UI for netcardmgr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built a UI that allows the user to enter preferred IPv4 network interface settings like a static IP address, static DNS servers, static default gateway, etc. Currently the UI will automatically populate the network settings from the interface you choose to modify from the network manager drop down menu.
Currently working on the function that will apply the settings in the UI to the correct interfaces.
Future UI changes should include an additional tab for IPv6 settings as well as easy to configure VPN tab.