Skip to content

Conversation

@jcollie
Copy link
Member

@jcollie jcollie commented Mar 19, 2025

Changes:

  1. Require blueprint-compiler 0.16.0 (or newer) for building from a git checkout. With build: distribute gresource c/h with source tarball #6822 distributions that can't meet that requirement can use generated source tarballs to build.
  2. Remove all .ui files as they are unnecessary.
  3. Simplify the Builder interface since raw .ui files are no longer used.
  4. Removed build-time check of raw .ui files.

@jcollie jcollie requested a review from a team as a code owner March 19, 2025 22:01
@jcollie
Copy link
Member Author

jcollie commented Mar 19, 2025

Update of #6762

@jcollie
Copy link
Member Author

jcollie commented Mar 20, 2025

This needs updates to the snap packaging. I decided to do that as a separate PR (#6831) instead of tacking it all onto this one.

Changes:

1. Require `blueprint-compiler` 0.16.0 (or newer) for building from
   a git checkout. With ghostty-org#6822 distributions that can't meet that
   requirement can use generated source tarballs to build.
2. Remove all `.ui` files as they are unnecessary.
3. Simplify the `Builder` interface since raw `.ui` files are no
   longer used.
4. Removed build-time check of raw `.ui` files.
@jcollie jcollie force-pushed the gtk-builder-update branch from 662830c to 75cc4b2 Compare April 23, 2025 15:35
@mitchellh
Copy link
Contributor

I think all our dependent PRs are merged. Is this safe to merge?

@jcollie
Copy link
Member Author

jcollie commented May 6, 2025

Yeah this is good to go.

@jcollie jcollie merged commit 27cdd6d into ghostty-org:main May 6, 2025
38 checks passed
@jcollie jcollie deleted the gtk-builder-update branch May 6, 2025 21:06
@github-actions github-actions bot added this to the 1.2.0 milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants