Skip to content

Autoscaling destroy all previous container on first action #41

@mbovo

Description

@mbovo

Using docker 17.06 very first action performed by orbiter will destroy all previous running containers instead scaling up or down.

Server:
 Version:      17.06.0-ce
 API version:  1.30 (minimum version 1.12)
 Go version:   go1.8.3
 Git commit:   02c1d87
 Built:        Fri Jun 23 21:21:56 2017
 OS/Arch:      linux/amd64
 Experimental: false

The effect: when docker first receive a request with old api signature will apply an operation of "service update" with new replica value. This actually will scale up/down as requested AND will restart all previous running containers with the update policy defined.
In case there was only one previous container running this lead to a service unavailability during restarts

The cause: API changes from github.com/docker/docker 1.13.1 used by orbiter and the latest used by docker 17.06. Latest version has a different signature on method ServiceInspectWithRaw ( line 17 here ) adding new parameter of type types.ServiceInspectOptions ( godoc )

Solution proposed is to update docker client lib and change call to ServiceInspectWithRaw method.
@gianarb I'm preparing a pull request but this changed could potentially impact other aspects or functionalities.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions