Generate Event

[theopeudupin]

Hello,

In our previous cluster cleaning tool kube-janitor, event were generated when a ressource is deleted.

It was useful because the users of our cluster can see what ressources was deleted if they wanted to investigate a problem.
Im aware of the notification fonctionnality, which is very nice, but we would also like to have the deletion (and modification) event in the cluster event log.

Is it possible to have the behavior with K8S Cleaner at this time ?

Thank you in advance for your time.

[gianlucam76]

Hi @theopeudupin

Currently k8s-cleaner evaluates Cleaner instance based on Spec.Schedule
When it is time to process a Cleaner instance, k8s-cleaner collects and evaluates resources (if a resource is marked as deleted and still present due to a finalizer, k8s-cleaner ignores it by default, but setting this you can change that behavior.

Now, uf I am reading your request correctly, you want an event to be generated when a resource is deleted/modified (at the time the resource is deleted/modified).

That is then something cleaner is not designed to do. Sveltos can be programmatically told to watch for any conditions (like resource modified/deleted) and generate and event as soon as conditions happen.

[theopeudupin]

I have created the PR
Let me know if I can help

Thank you

[gianlucam76]

Thank you @theopeudupin

The way I was thinking was to add Kubernetes events as notification type:

k8s-cleaner/api/v1alpha1/cleaner_types.go

Line 124 in 3952122

// +kubebuilder:validation:Enum:=CleanerReport;Slack;Webex;Discord;Teams;SMTP;Telegram

Then in

k8s-cleaner/internal/controller/executor/notifications.go

Line 71 in 3952122

func sendNotifications(ctx context.Context, resources []ResourceResult,

call it

So generating Kubernetes events can asked in a Cleaner instance and asked not only for deleted objects but also for modified objects

What do you think?

[theopeudupin]

That would be awesome !

I wouldn't be able to implement this myself but that would exaclty match my needs 👍

[gianlucam76]

I will take care of it early next week. Thank you!

[gianlucam76]

To ask cleaner to generate Events for matching resources add events to notifications section

  notifications:      
  - name: events      
    type: Event 

Here is an example of Event that will be generated

19s                 Normal   k8s-cleaner               ConfigMap/kube-root-ca.crt              [ns:default] resource matching Cleaner instance unused-configmaps (current action Scan)

It reports:

1. the resource Kind, [namespace], name
2. the action taken by Cleaner (delete, modify, scan)
3. the name of the Cleaner Instance

[gianlucam76]

#311