Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Fix nil value new price #1

Open
wants to merge 43 commits into
base: remove-deprecated-values
Choose a base branch
from

Commits on Apr 16, 2023

  1. Remove deprecated attributes from apps requests (fastlane#21187)

    * Remove prices from ESSENTIAL_INCLUDES closes fastlane#21125
    
    * Fix spec
    
    * Fix violations
    
    * Fix stubs
    giginet committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    f7e0075 View commit details
    Browse the repository at this point in the history
  2. [ci] Only run all mac jobs on master and version bump branches (fastl…

    …ane#21088)
    
    * [ci] Only run all mac jobs on master and version bump branches
    
    * Fix main to master
    joshdholtz committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    cd81a01 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b8c1a22 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Configuration menu
    Copy the full SHA
    08e5093 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    b3ae1b0 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. [match] Adding support for self-managed GitLab instances (fastlane#21274

    )
    
    * Adding support for self-managed GitLab instances
    
    * Adding gitlab_host option to the match generator
    
    * Fixing rubocop issues
    darbyfrey committed May 13, 2023
    Configuration menu
    Copy the full SHA
    7b3e224 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. [scan] run simulator destination with arch=x86_64 for Xcode 14.3 and …

    …up if on Intel (fastlane#21284)
    
    * Added arch=x86_64 for scan
    
    * Make as an option
    
    * Only do for iOS
    joshdholtz committed May 17, 2023
    Configuration menu
    Copy the full SHA
    586b13f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e0149b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8aed4cc View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    0ede7e7 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. updates prici (fastlane#21282)

    ng tier election to correctly handle nil value
    lukethoene committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0495da3 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. [match] Add access token prompt for GitLab Secure Files Match (fastla…

    …ne#21279)
    
    * Adding access token prompt for GitLab Secure Files Match
    
    * Removing commented code
    darbyfrey committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    ba801c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. [match] Fixes Gitlab Secure Files API limit (fastlane#21361)

    Co-authored-by: Darby Frey <dfrey@gitlab.com>
    darbyfrey and Darby Frey committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    37f2f6c View commit details
    Browse the repository at this point in the history
  2. [docs][match] fix typos, improve wording, incorporate improvements to…

    … match documentation examples (fastlane#21302)
    
    * Incorporate changes made in fastlane/docs#1196.
    
    * Improve wording and fix typos.
    rogerluan committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    4635534 View commit details
    Browse the repository at this point in the history
  3. [actions] Fix fastlane action template warnings reported by Rubocop (f…

    …astlane#21310)
    
    * Fix Style/StringLiterals RuboCap warning
    
    More information about warning:
    https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/StringLiterals
    
    * Fix indentation of template Action, reported by Rubocop
    
    https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/IndentationWidth
    
    * Fix Layout/LineLength: Line is too long, reported by Rubocop
    
    More information:
    https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Layout/LineLength
    
    * Fix Style/MethodCallWithArgsParentheses reported by Rubocop
    
    * Fix Style/ParenthesesAroundCondition, Style/AndOr and Style/Not
    
    Fixes:
    * Style/ParenthesesAroundCondition: Don't use parentheses around the condition of an unless.
    * Style/AndOr: Use && instead of and.
    * Style/Not: Use ! instead of not.
    bartoszkosiorek committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e70b3d1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f00b39b View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. [supply][action] add download_apk_from_google_play action (and corr…

    …esponding `supply` methods) (fastlane#21315)
    
    * [Supply] Listing & downloading generated APKs
    
    Add methods on the Supply client to list and download Universal Generated APKs from the Google Play Console — typically generated and code-signed by Google from the AAB you uploaded e.g. via the `upload_to_play_store`/`supply` action
    
    * [Action] download_universal_apk_from_google_play
    
    Very useful when you use [Play App Signing](https://support.google.com/googleplay/android-developer/answer/9842756) and thus don't necessary have the signing key to produce the APK yourself.
    In those cases, you typically only upload an AAB to GPC, then let Google code-sign and generate signed APKs from that AAB.
    
    * Add `download_universal_apk_from_google_play` to `unused_options_spec` exceptions
    
    Because most of the options that are detected as not being used directly by the action are in fact just passed along to Supply::Client.make_from_config
    AliSoftware committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    5030f31 View commit details
    Browse the repository at this point in the history
  2. [spaceship] add update method to ConnectAPI::User (fastlane#20956)

    * [spaceship] add update method to ConnectAPI::User
    
    * Apply suggestions from @rogerluan
    
    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    
    * chore: move UserRolse to User and use link in UserInvitation
    
    * Update spaceship/lib/spaceship/connect_api/models/user.rb
    
    * Apply suggestions from code review
    
    Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    Co-authored-by: Iulian Onofrei <5748627+revolter@users.noreply.github.com>
    3 people committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    18f7716 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Fix olympus session request error after skipping 2FA Upgrade (fastlan…

    …e#21317)
    
    * Fix olympus session request error after skipping 2FA Upgrade
    
    Request to : https://appstoreconnect.apple.com/olympus/v1/session are now rejectec if account is not configured with 2FA.
    Skipping this request avoid non 2FA account to get stuck without authentication.
    
    * Fix olympus session request error after skipping 2FA Upgrade
    
    Request to : https://appstoreconnect.apple.com/olympus/v1/session are now rejectec if account is not configured with 2FA.
    Skipping this request avoid non 2FA account to get stuck without authentication.
    Removing comment for lint
    AbbyM committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    3d2d208 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Configuration menu
    Copy the full SHA
    600555c View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Configuration menu
    Copy the full SHA
    4ac1d96 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Configuration menu
    Copy the full SHA
    239b738 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a2c5392 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Configuration menu
    Copy the full SHA
    614eadf View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. [ci] fix CI by replacing deprecated Xcode versions, and add Xcode 14,…

    … Xcode 15, and Ruby 3.1 to test envs (fastlane#21465)
    
    * Remove/replace old Xcode versions not supported by CircleCI anymore.
    
    * Add two new macOS environments: Xcode 14 and 15.
    
    * Change to Ruby 3.1 because 3.2 is not available.
    
    * Remove new Xcode versions so it can be added in a separate PR.
    
    * Add missing name and xcode_version.
    
    * Fix specs related to upgrade of OpenSSL version on Ruby 3.1.
    
    * Upgrade http-cookie to 1.0.5 to support Ruby 3.
    
    * Revert "Add missing name and xcode_version."
    
    This reverts commit cf56b93.
    
    * Revert "Remove new Xcode versions so it can be added in a separate PR."
    
    This reverts commit 34741c5.
    
    * Move dependency from development to regular one.
    
    * Sort dependencies alphabetically.
    
    * Update Gemfile.lock after updating gemspec.
    
    * RuboCop: apply `Style/FetchEnvVar` rule throughout codebase.
    
    https://docs.rubocop.org/rubocop/1.56/cops_style.html#stylefetchenvvar
    
    * Update Rubocop from 1.12.1 to 1.56.0 (latest) to support Ruby 3.1.
    
    * Regenerate Rubocop TODO file.
    
    * Revert "RuboCop: apply `Style/FetchEnvVar` rule throughout codebase."
    
    This reverts commit e122484.
    
    * Downgrade Rubocop to keep support to Ruby 2.6.
    
    * Fix all Rubocop linter issues detected in Plugins templates.
    
    * Revert changes to fix dynamic versions used in template.
    
    * Remove outdated comment.
    
    * Use specific Ruby version to see if CircleCI is able to detect them.
    
    * Move rubocop rule to where it's being actually used.
    
    * Code style.
    
    * Fix syntax.
    
    * Massage dependencies versions to resolve compatibility issues.
    
    * Revert version bump to keep support for Ruby 2.
    
    * Fix rspec crashes when running Ruby 3.2 by upgrading `fakefs` gem.
    
    * Move back to Ruby 3.1.
    
    * Revert "Fix rspec crashes when running Ruby 3.2 by upgrading `fakefs` gem."
    
    This reverts commit fda2881.
    
    * Specify full Ruby versions for 2.6 and 2.7.
    
    * Temporarily comment out condition to test other Ruby envs.
    
    * Revert "Temporarily comment out condition to test other Ruby envs."
    
    This reverts commit adac361.
    
    * Revert unintentional changes to dependency versions.
    
    * Revert unintentional changes to dependency versions.
    rogerluan committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d7aab9c View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    dbb84f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2023

  1. Configuration menu
    Copy the full SHA
    6c76839 View commit details
    Browse the repository at this point in the history
  2. [docs] update pull request template to ask contributors to write unit…

    … tests (fastlane#21427)
    
    * Update PR template.
    
    * Modify wording.
    rogerluan committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    f694de4 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. [testflight] Explicit beta group access to all builds at creation (fa…

    …stlane#21478)
    
    * Let you specify beta group access to all builds at creation
    
    * Add tests for access to all builds
    vincentisambart committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ff74e77 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65db20a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. [match] prevent directory download from s3 (fastlane#20975)

    * fix: prevent directory download from s3
    
    * chore: add test to verify file-like s3 downloads
    
    * Update match/lib/match/storage/s3_storage.rb
    
    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    
    ---------
    
    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    markhomoki and rogerluan committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    ab9fb32 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. [docs] add minor branding guidelines to CONTRIBUTING.md (fastlane#2…

    …1495)
    
    * Add minor branding guidelines.
    
    * Improve checks on branding style.
    
    * Prefer `lowercase` over `lower case`.
    
    https://english.stackexchange.com/a/59413
    
    * Adequate existing docs to branding guidelines.
    
    * Improve lowercase checking algorithm to cover all wEiRD caSEs.
    
    * Improve wording.
    
    Co-authored-by: Aaron Brager <getaaron@gmail.com>
    
    * Refactor regex to take into account potential false positives.
    
    * Add unit tests for the tool name formatting tests.
    
    * Use full name for the variable.
    
    * Add missing test cases and fix typo in method.
    
    * Move test to actual specs.
    
    * Run rubocop.
    
    * Commit missing part.
    
    * Remove emoji indicators.
    
    * Remove emoji from specs too 😅
    
    * Use File.readlines instead of File.read + split
    
    * Also detect formatting issues at start of line
    
    * Fix violations found by new implementation
    
    * Add the "features" word back to the table.
    
    ---------
    
    Co-authored-by: Aaron Brager <getaaron@gmail.com>
    Co-authored-by: Olivier Halligon <olivier@halligon.net>
    3 people committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    8c1fc73 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    6627c28 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. [spaceship] validate the status of app version to be ready_for_review…

    … before submitting the app (fastlane#20515)
    
    * validate the status of app version to be ready_for_review before submitting the app
    
    * only retries at most 10 times
    404pilot committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    871eb67 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. [supply] introduce a new synchronization logic for screenshots (fastl…

    …ane#21498)
    
    * [supply] Implement screenshots upload sync
    
    Compare the checksum of the images to be uploaded with the ones already in remote, and skip upload if they already match
    
    * Add unit tests
    
    * Improve YARD doc
    
    * fix typo in comment
    
    * Apply suggestions from code review
    
    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    
    * Remove redundant condition
    
    * Add assertion about not deleting _all_ screenshots when `sync_image_upload` is set
    
    ---------
    
    Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
    AliSoftware and rogerluan committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    be470ec View commit details
    Browse the repository at this point in the history
  2. Add request retry with backoff when encountring 429 errors (fastlane#…

    …21511)
    
    * Add request retry with backoff when encountring 429 errors
    
    * Fix lint errors
    
    ---------
    
    Co-authored-by: Josh Holtz <me@joshholtz.com>
    snatchev and joshdholtz committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    c04f975 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. Configuration menu
    Copy the full SHA
    271f2d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. [supply] add new SUPPLY_UPLOAD_MAX_RETRIES env var to attempt to solv…

    …e failed Google API calls (fastlane#21518)
    
    * [supply] add new SUPPLY_UPLOAD_MAX_RETRIES env var to attempt to solve failed Google API calls
    
    * Rewrite expectation to ensure SUT is interrupted by raised error
    
    Otherwise if we just `expect(UI).to receive(:user_error!).with(…)` that will mock the `UI.user_error` call in the method being tested... and thus not make it `raise` anymore, which the rest of the implementation of that method will continue executing when run in the context of mocked tests while it would not in the real world, which means we would be testing a different behavior of the method
    
    ---------
    
    Co-authored-by: Olivier Halligon <olivier@halligon.net>
    joshdholtz and AliSoftware committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    3bbbebd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f06aa50 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Configuration menu
    Copy the full SHA
    27dc84d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    4257191 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. resolve undefined var

    Sofian committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    f23b138 View commit details
    Browse the repository at this point in the history
  2. remove startDate nil value

    Sofian committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    0ab91f2 View commit details
    Browse the repository at this point in the history