Skip to content

Fix off-by-two padding bug in set_string and empty string edge case #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gijzelaerr merged 1 commit into from
Mar 10, 2026
Merged

Fix off-by-two padding bug in set_string and empty string edge case #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions snap7/util/setters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,12 @@ def set_fstring(bytearray_: bytearray, byte_index: int, value: str, max_length:
if size > max_length:
raise ValueError(f"size {size} > max_length {max_length} {value}")

i = 0

# fill array which chr integers
# fill array with chr integers
for i, c in enumerate(value):
bytearray_[byte_index + i] = ord(c)

# fill the rest with empty space
for r in range(i + 1, max_length):
for r in range(len(value), max_length):
bytearray_[byte_index + r] = ord(" ")


Expand Down Expand Up @@ -237,14 +235,12 @@ def set_string(bytearray_: bytearray, byte_index: int, value: str, max_size: int
# set len count on first position
bytearray_[byte_index + 1] = len(value)

i = 0

# fill array which chr integers
# fill array with chr integers
for i, c in enumerate(value):
bytearray_[byte_index + 2 + i] = ord(c)

# fill the rest with empty space
for r in range(i + 1, bytearray_[byte_index] - 2):
for r in range(len(value), bytearray_[byte_index]):
bytearray_[byte_index + 2 + r] = ord(" ")


Expand Down