Skip to content

Improve test coverage for recent features#655

Merged
gijzelaerr merged 2 commits intomasterfrom
improve-test-coverage
Mar 25, 2026
Merged

Improve test coverage for recent features#655
gijzelaerr merged 2 commits intomasterfrom
improve-test-coverage

Conversation

@gijzelaerr
Copy link
Copy Markdown
Owner

Summary

  • Add 20 new tests covering identified coverage gaps
  • CLI discover command (5 tests): help output, devices found/empty, timeout passthrough, import error handling
  • Legitimation failure paths (7 tests): not connected, no TLS, no OMS secret, empty password, short challenge, double authenticate, key rotation
  • S7CommPlus async client (6 tests): connect/disconnect, db_read, db_write+readback, context manager, properties, legacy fallback property
  • Heartbeat concurrency (2 tests): rapid sequential reads and writes during active heartbeat probing

Test plan

  • All 20 new tests pass
  • Full suite passes (1304 passed, 84 skipped)
  • ruff check clean
  • mypy clean

🤖 Generated with Claude Code

gijzelaerr and others added 2 commits March 25, 2026 11:31
…heartbeat

New test file covering identified coverage gaps:
- CLI discover command: help, devices found/not found, timeout, import error
- Legitimation failure paths: not connected, no TLS, no OMS secret, edge cases
- S7CommPlus async client: connect, read, write, context manager, properties
- Heartbeat concurrency: rapid reads and writes during active heartbeat

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@gijzelaerr gijzelaerr force-pushed the improve-test-coverage branch from b76042c to ab91851 Compare March 25, 2026 09:31
@gijzelaerr gijzelaerr merged commit 667f97c into master Mar 25, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant