Skip to content

added discord server to readme.md#36

Merged
gilzoide merged 2 commits intogilzoide:mainfrom
TrainzMarcel:patch-1
Jan 14, 2023
Merged

added discord server to readme.md#36
gilzoide merged 2 commits intogilzoide:mainfrom
TrainzMarcel:patch-1

Conversation

@TrainzMarcel
Copy link
Copy Markdown
Contributor

No description provided.

@gilzoide
Copy link
Copy Markdown
Owner

gilzoide commented Jan 5, 2023

Thanks for the addition.
To be honest, I like better these badges at the top, just after the title. Just like Shield.io's own repo README, although I see no need to have them centralized.
If we add more badges, they all live in the same place and we cut the explanation texts, since these badges are quite self-explanatory. Now that I'm thinking of it, a badge linking to the Godot Asset Library would be a nice addition, I'll add it later.
What do you think?

@TrainzMarcel
Copy link
Copy Markdown
Contributor Author

TrainzMarcel commented Jan 5, 2023

good idea! i myself didnt know where to put the discord badge and i thought it looked out of place there without an explanation. feel free to move it around however u like and remove the explanation

@gilzoide
Copy link
Copy Markdown
Owner

gilzoide commented Jan 7, 2023

feel free to move it around however u like and remove the explanation

I'm not merging your PR only to change everything you added right after.
Change it in your branch, then I'll merge it in the right place and your name will be kept in the blame ^^

@TrainzMarcel
Copy link
Copy Markdown
Contributor Author

sorry that took so long, i had a busy week

@gilzoide
Copy link
Copy Markdown
Owner

Don't worry about that, I know how that goes.
I think it's better now, at the top of the README, thanks for the contribution!

@gilzoide gilzoide merged commit a889bde into gilzoide:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants