Skip to content

Conversation

@koenno
Copy link
Contributor

@koenno koenno commented Sep 25, 2024

fixed #46

Before gzip writer close it is checked if anything has been written to the writer. If not the writer is replaced by discard one what directs gzip footer not to be written in to a response body.

@appleboy appleboy changed the title discard gzip footer when empty body chore: discard gzip footer when empty body Dec 24, 2024
@appleboy appleboy merged commit fb15f54 into gin-contrib:master Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If enable the gzip middleware, the gin server returns an incorrect response for 404 status by default

2 participants