fix(context): (context.Context).Err() returns DeadlineExceeded #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, when a timeout occurs, the ctx.Request.Context().Err() method returns a context.Canceled. However, in the case of a timeout, we expect the context.DeadlineExceeded to be returned.
This pull request addresses the timeout error handling. By modifying to return context.DeadlineExceeded when a timeout occurs, we enhance the consistency of error handling.
Changes Made
Reviewed and revised timeout error handling to return the context.DeadlineExceeded instead of the context.Canceled using ctx.Request.Context().Err().
Testing
Added test cases that trigger timeouts with the applied changes. This ensures that the modifications function correctly and the expected error is returned.