Conversation
cowleyk
commented
Aug 24, 2017
| @@ -1,7 +1,5 @@ | |||
| from nio.block.terminals import DEFAULT_TERMINAL | |||
| from nio.block.terminals import DEFAULT_TERMINAL | ||
| from nio.signal.base import Signal | ||
| from nio.testing.block_test_case import NIOBlockTestCase | ||
| from ..track_objects_block import TrackObjects |
| super().setUp() | ||
| sys.modules['cv2'] = MagicMock() | ||
| sys.modules['object_tracker'] = MagicMock() | ||
| sys.modules['imutils'] = MagicMock() |
Collaborator
Author
There was a problem hiding this comment.
I had to adjust this to get the tests to run locally on my machine, if you don't think this is correct feel free to ignore
| @@ -1,6 +1,4 @@ | |||
| from collections import deque | |||
| @@ -1,6 +1,4 @@ | |||
| from collections import deque | |||
| from enum import Enum | |||
| import numpy as np | |||
| def process_signals(self, signals): | ||
| counter = 0 | ||
| (dX, dY) = (0, 0) | ||
| direction = "" |
Collaborator
Author
There was a problem hiding this comment.
these variables aren't used anywhere, not sure if they're required by openCV?
Owner
There was a problem hiding this comment.
Those we're used by some functionality that I took out. So they can be removed
| break | ||
|
|
||
| frame = imutils.resize(frame, width=600) | ||
| blurred = cv2.GaussianBlur(frame, (11, 11), 0) |
Collaborator
Author
There was a problem hiding this comment.
this isn't used anywhere, but may be a future feature?
gingajake
approved these changes
Aug 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing the
range-detector.pyfile is there for a reason, but want to note that it isn't actually used in the block code