Conversation
add gsBasis::getElements
add gsBasis::getElements (2)
fix bcs
add gsL2Projection add gsBasis::degreeElevate add new constructors gsMultiPatch and gsMultiBasis add getters (pointers) for gsSparseMatrix
There was a problem hiding this comment.
Pull Request Overview
This PR extends the C API by adding new refinement and cloning operations, sparse‐matrix support, element‐export functions, and high‐level approximate operators (quasi‐interpolation and L2 projection).
- Added C wrappers for geometry and basis cloning, element export, and refine operations
- Exposed sparse matrix internals and triplet interfaces in the C layer
- Introduced new modules for quasi‐interpolation and L2 projection
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gsCVectorInt.cpp | Updated int‐vector wrappers: drop gismo:: prefix, add extern "C" |
| src/gsCVector.cpp | Updated double‐vector wrappers similarly |
| src/gsCSparseMatrix.h | Declared pointer accessors and triplet APIs for sparse matrices |
| src/gsCSparseMatrix.cpp | Implemented new sparse‐matrix C functions |
| src/gsCReadFile.h | Added gsCWriteFile declaration |
| src/gsCReadFile.cpp | Prefixed info message, added C API includes |
| src/gsCQuasiInterpolate.h | New quasi‐interpolation function declarations |
| src/gsCQuasiInterpolate.cpp | Implemented local/Taylor/Schoenberg wrappers |
| src/gsCQuadRule.cpp | Updated quadrature rule wrappers to use using namespace gismo |
| src/gsCOptionList.cpp | Updated option‐list wrappers |
| src/gsCNurbsCreator.cpp | Updated NURBS creator wrappers |
| src/gsCMultiPatch.h | Declared multi‐patch creation, IO, refine, embed, degree elevate |
| src/gsCMultiPatch.cpp | Implemented multi‐patch C API |
| src/gsCMultiBasis.h | Declared multi‐basis creation and IO |
| src/gsCMultiBasis.cpp | Implemented multi‐basis C API |
| src/gsCMatrixInt.cpp | Updated integer‐matrix wrappers |
| src/gsCMatrix.cpp | Updated double‐matrix wrappers |
| src/gsCL2Projection.h | Added L2 projection C API |
| src/gsCL2Projection.cpp | Implemented L2 projection wrapper |
| src/gsCKnotVector.cpp | Updated knot‐vector wrappers |
| src/gsCGeometryTransform.cpp | Updated geometry‐transform wrappers |
| src/gsCGeometry.h | Added geometry IO, cloning, and refine declarations |
| src/gsCGeometry.cpp | Implemented geometry IO, clone, refine (contains merge conflict) |
| src/gsCFunctionSet.h | Declared new derivative and multi‐derivative evaluation APIs |
| src/gsCFunctionSet.cpp | Implemented new function‐set wrappers and print formatting |
| src/gsCFunctionExpr.cpp | Updated function‐expression wrappers |
| src/gsCFitting.cpp | Updated fitting wrappers |
| src/gsCBoundaryConditions.cpp | Updated BC wrapper and reordered addCondition parameters |
| src/gsCBasis.h | Added basis IO, clone, degree elevate, boundary, and element export APIs |
| src/gsCBasis.cpp | Implemented new basis C API and HTensor element routines |
| src/Cgismo.h.in | Included new quasi‐interpolate and L2‐projection headers |
Comments suppressed due to low confidence (3)
src/gsCGeometry.h:46
- New refinement function
gsGeometry_refinelacks accompanying C‐API tests. Consider adding tests that exercise multi‐box refinement.
GISMO_EXPORT void gsGeometry_refine(gsCGeometry * b, gsCMatrix * boxes, int refExt);
src/gsCBasis.h:56
- Element export API
gsBasis_elements_intois new; include unit tests to verify the returned matrix of element bounds.
GISMO_EXPORT void gsBasis_elements_into(gsCBasis * b, gsCMatrix*);
src/gsCGeometry.cpp:154
- Leftover merge conflict markers (
<<<<<<< HEAD/=======/>>>>>>> main) must be resolved before compilation.
<<<<<<< HEAD
hverhelst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADD:
gsBasis::elements_into,gsHTensorBasis::elements_into)