Add optional callback performed before step to gsDynamicBase.h#28
Merged
Conversation
hverhelst
requested changes
Jun 23, 2026
hverhelst
left a comment
Member
There was a problem hiding this comment.
Thanks! Small change (did not compile it) for clarity
Contributor
There was a problem hiding this comment.
Pull request overview
Enables users of gsDynamicBase time integrators (e.g., Newmark) to run custom logic immediately before each non-const timestep, supporting workflows like enforcing prescribed boundary velocities and recomputing consistent states.
Changes:
- Added a configurable pre-step callback API to
gsDynamicBaseand invoked it at the start ofstep(T dt). - Ensured
m_statusis updated with the result of_step(...)instep(T dt). - Added missing
#pragma oncetogsStructuralAnalysisTypes.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/gsStructuralAnalysisTools/gsStructuralAnalysisTypes.h |
Adds #pragma once to avoid multiple-inclusion issues. |
src/gsDynamicSolvers/gsDynamicBase.h |
Adds pre-step callback support and updates step status bookkeeping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…er refers to arc-length methods.
hverhelst
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have some boundary DOFs with prescribed velocities. Every Newmark timestep, I needed to compute consistens accelerations/positions, and resulting internal forces. This change enables that by making it possible to inject a callback.
Also, a #pragma once was missing.