feat: add default ignore patterns for protobuf-generated files#1111
Merged
feat: add default ignore patterns for protobuf-generated files#1111
Conversation
Add *.pbobjc.h, *.pbobjc.m, *.pb.go, *.pb.h, *.pb.cc, *_pb2.py, *_pb2_grpc.py, *.pb.swift, and *.pb.dart to DEFAULT_IGNORE_PATTERNS so protobuf-generated code is excluded from tracking by default. Closes #1103 Co-Authored-By: Sasha Varlamov <sasha@sashavarlamov.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 9 protobuf-generated file patterns to
DEFAULT_IGNORE_PATTERNSinsrc/authorship/ignore.rsso thatprotocoutput is excluded from git-ai tracking by default. Previously, these files were counted as human-authored code, inflating human line counts and diluting AI acceptance rates.New patterns:
*.pbobjc.h,*.pbobjc.m,*.pb.go,*.pb.h,*.pb.cc,*_pb2.py,*_pb2_grpc.py,*.pb.swift,*.pb.dart.Java/Kotlin protobuf outputs are intentionally excluded—they generate ordinary
.java/.ktfilenames with no distinguishing suffix. Users can handle those via.gitattributeslinguist-generatedor.git-ai-ignore, which are already supported.Closes #1103
Review & Testing Checklist for Human
.git-ai-ignoreor config).*.pb.h/*.pb.cc: verify there are no common non-protobuf naming conventions that use.pb.as a double extension in C++ headers/sources.Notes
reuse_tests_in_worktree!.Link to Devin session: https://app.devin.ai/sessions/f4b349e42ecd4f5081c5876e28a5093f
Requested by: @svarlamov