chore(authorship): remove dead LineRange::overlaps and CheckpointKind::from_str#1333
Open
jwiegley wants to merge 1 commit into
Open
chore(authorship): remove dead LineRange::overlaps and CheckpointKind::from_str#1333jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
This was referenced May 11, 2026
Contributor
Author
This was referenced May 11, 2026
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
jwiegley
force-pushed
the
dc/authorship-serialization-cleanup
branch
from
9ed496f to
e0142df
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
2 times, most recently
from
6037a11 to
97d01b8
Compare
jwiegley
force-pushed
the
dc/authorship-serialization-cleanup
branch
from
e0142df to
4f7a1d2
Compare
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
97d01b8 to
7554d6e
Compare
…::from_str LineRange::overlaps had zero callers — callers of overlaps throughout the codebase target LineAttribution::overlaps(u32, u32) or Attribution::overlaps(usize, usize), which have different signatures. CheckpointKind::from_str was similarly unreachable; checkpoint kinds are matched via serde deserialization, not string parsing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/authorship-helpers-cleanup
branch
from
7554d6e to
7be185c
Compare
jwiegley
force-pushed
the
dc/authorship-serialization-cleanup
branch
from
233d28d to
699f929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LineRange::overlaps had zero callers — all .overlaps() calls in the codebase target LineAttribution::overlaps(u32,u32) or Attribution::overlaps(usize,usize) which have different signatures. CheckpointKind::from_str was unreachable; checkpoint kinds are matched via serde deserialization.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code