Conversation
acunniffe
commented
Nov 1, 2025
| authorship::working_log::CheckpointKind, observability::log_performance, utils::debug_log, | ||
| }; | ||
|
|
||
| pub fn log_performance_target_if_violated( |
Collaborator
Author
There was a problem hiding this comment.
@svarlamov let's sync on defining our internal targets.
Member
There was a problem hiding this comment.
Sounds good. The biggest thing I noticed in playing around with it is that we probably need to set a floor on the 10% (at least for now). So like max(10% or 70ms)
➜ git-ai git:(feat/sentry) GIT_AI_DEBUG_PERFORMANCE=1 git commit
On branch feat/sentry
Your branch is up to date with 'origin/feat/sentry'.
nothing to commit, working tree clean
[git-ai (perf)] ᕽ Performance target violated for command: commit. Total duration: 51ms, Git duration: 7ms. Pre-command: 44ms, Post-command: 0ms.
008f7c5 to
a46c576
Compare
|
you ████████████████████████░░░░░░░░░░░░░░░░ ai AI code tracked with git-ai |
svarlamov
approved these changes
Nov 2, 2025
Member
svarlamov
left a comment
There was a problem hiding this comment.
Everything looks good. Left some thoughts on the thresholds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for logging performance metrics + errors to Sentry compatible endpoints
OSS releases will have telemetry enabled by default starting in
1.0.15. There's a flag inconfig.jsonto disable itEnterprises can set their own DSN using
Or by building from source and setting
SENTRY_ENTERPRISE=<dsn> cargo build--
what's logged?
--
performance impact
because git-ai is a git wrapper and does not want to introduce any major overhead to a git command. So we're trading realtime logs for performance. Logs are buffered in an append-only
ai/logfile (one per pid to prevent locking). Logs are then sent to the server only when you do a git fetch or git push. A background process is enqueued to mop up the logs and send them off without slowing those commands down.