Fix: Use BFS to collect all commits in walk_commits_to_base for --rebase-merges support#331
Closed
txf0096 wants to merge 1 commit intogit-ai-project:mainfrom
txf0096:fix/bfs-walk-commits-clean
Closed
Fix: Use BFS to collect all commits in walk_commits_to_base for --rebase-merges support#331txf0096 wants to merge 1 commit intogit-ai-project:mainfrom txf0096:fix/bfs-walk-commits-clean
txf0096 wants to merge 1 commit intogit-ai-project:mainfrom
txf0096:fix/bfs-walk-commits-clean
Conversation
…ase-merges support The walk_commits_to_base function was only following parent(0), causing it to miss commits from merged branches when using git rebase --rebase-merges. This resulted in AI authorship being lost for side branch commits. Changed from linear traversal (parent(0) only) to BFS (Breadth-First Search) that traverses all parents, ensuring merge commits' second parents are not missed. Fixes #328
|
shawn.tian seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Use BFS to collect all commits in
walk_commits_to_basefor--rebase-mergessupportProblem
The
walk_commits_to_basefunction only followsparent(0), causing commits from merged branches to be lost duringgit rebase --rebase-merges. This results in AI authorship data being lost for side branch commits.Fixes the failing
test_rebase_preserve_mergesintegration test.Solution
Replace linear traversal with BFS (Breadth-First Search) to traverse all parent commits, ensuring merge commits' second parents are not missed.
Changes
File:
src/authorship/rebase_authorship.rsBefore (Lines 823-841):
After:
Test Results
Before
After
Impact
--rebase-mergesauthorship trackingChecklist
Additional Notes
This is a critical fix for users relying on
git rebase --rebase-mergesto preserve merge commit structure. Without this fix, AI authorship data is silently lost for all commits in merged branches.