Skip to content

Add a Makefile with common cargo targets, and a lint-and-format CI action#456

Merged
svarlamov merged 5 commits intogit-ai-project:mainfrom
jwiegley:johnw/lint-format
Feb 7, 2026
Merged

Add a Makefile with common cargo targets, and a lint-and-format CI action#456
svarlamov merged 5 commits intogit-ai-project:mainfrom
jwiegley:johnw/lint-format

Conversation

@jwiegley
Copy link
Copy Markdown
Contributor

@jwiegley jwiegley commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

jwiegley and others added 4 commits February 6, 2026 21:45
Provides make targets for build, test, bench, lint (check + clippy),
doc, format, and update, with an `all` target that runs build, test,
lint, and doc.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds a GitHub Actions workflow pinned to Rust 1.93.0 that runs five
parallel jobs: format check (cargo fmt --check), lint (make lint with
warnings as errors), build (with warnings as errors), test (compile
and run with warnings as errors), and doc (with doc warnings as
errors). Uses dtolnay/rust-toolchain and cargo caching.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
These jobs already exist in the main CI pipeline, so they are
redundant here. Keep only format, lint, and doc checks.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add missing `use std::collections::HashSet` in git_handlers.rs
- Gate macOS-only imports behind #[cfg(target_os = "macos")] in detection.rs
- Move #[allow(dead_code)] to module level in fork_app.rs
- Replace redundant closures with function references in opencode_preset.rs

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jwiegley jwiegley force-pushed the johnw/lint-format branch 2 times, most recently from 379c1a5 to 28fe098 Compare February 7, 2026 05:52
@svarlamov svarlamov enabled auto-merge February 7, 2026 06:24
@svarlamov svarlamov added this pull request to the merge queue Feb 7, 2026
Merged via the queue into git-ai-project:main with commit ca0d0c4 Feb 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants