statically link vcruntime140.dll in windows builds#495
statically link vcruntime140.dll in windows builds#495
vcruntime140.dll in windows builds#495Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| # Verify the binary actually runs (catches missing vcredist / DLL issues) | ||
| Write-Host 'Verifying binary...' | ||
| try { | ||
| $verOutput = & $finalExe version 2>&1 | ||
| if ($LASTEXITCODE -ne 0) { | ||
| Write-ErrorAndExit "git-ai binary failed to run (exit code $LASTEXITCODE). Output: $verOutput`nThis may indicate missing system libraries. Please report this at https://github.com/git-ai-project/git-ai/issues." | ||
| } | ||
| Write-Success "Binary verified: $verOutput" | ||
| } catch { | ||
| Write-ErrorAndExit "git-ai binary failed to execute: $($_.Exception.Message)`nThis may indicate missing system libraries (e.g. Visual C++ Redistributable). Please report this at https://github.com/git-ai-project/git-ai/issues." | ||
| } |
There was a problem hiding this comment.
🟡 Binary verification runs after exchange-nonce already executes the binary
The new binary verification step (lines 407-417) is designed to catch missing DLL/vcredist issues and provide a clear, actionable error message. However, it is placed after the exchange-nonce call at install.ps1:396-405, which already executes $finalExe. When $env:INSTALL_NONCE and $env:API_BASE are set, a DLL failure will first be caught by the exchange-nonce try/catch, silently setting $needLogin = $true and masking the real cause.
Detailed Explanation
When the binary has a missing DLL issue and the nonce env vars are set:
- Line 398 (
& $finalExe exchange-nonce) fails with a DLL load error - The catch block at line 402-404 silently sets
$needLogin = $true, treating it as a login issue - The verification at line 410 then also fails and calls
Write-ErrorAndExitwith the correct message
The verification step still catches the problem, so the user does get the right error eventually. However, the intent of the verification is to be the first execution of the binary to provide immediate, clear diagnostics. Moving the verification block before the exchange-nonce block would ensure the user always gets the clear DLL-related error message first, without any confusing intermediate behavior.
Impact: When INSTALL_NONCE and API_BASE are set and the binary has DLL issues, the user sees the correct error but only after an unnecessary failed nonce exchange attempt.
Prompt for agents
Move the binary verification block (lines 407-417 in install.ps1) to before the exchange-nonce block (currently lines 394-405). The verification should be the first thing that executes the binary after installation, so that missing DLL issues are caught with a clear error message before any other binary invocations. Specifically, move the block starting with '# Verify the binary actually runs' to just after line 393 (after the git-og shim creation), and before the '# Login user with install token if provided' comment.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Installs would silently fail for fresh windows machines without vcruntime