Fix post-commit stats not showing with git aliases#801
Closed
Fix post-commit stats not showing with git aliases#801
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The async (wrapper-daemon) code path parsed CLI args but never resolved git aliases before checking whether the command was "commit". When a user had e.g. `alias.cm = commit`, the parsed command was "cm" which didn't match, so post-commit stats were silently skipped. Add alias resolution in the async path (matching what the non-async wrapper path already does) and add a regression test that commits via an alias and asserts the stats bar appears. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
svarlamov
force-pushed
the
fix/async-mode-alias-post-commit-stats
branch
from
0a6f385 to
f952517
Compare
devin-ai-integration bot
added a commit
that referenced
this pull request
Mar 27, 2026
- Revert Clap removal from main.rs to preserve help/usage behavior - Restore is_repo_creating early-exit for clone/init in async mode that was dropped during the refactor, preventing the daemon from receiving misleading wrapper state for repo-creating commands - Port async_mode_post_commit_shows_stats_with_commit_alias test from PR #801 which is now subsumed by this PR's alias resolution changes - Fix clippy match_like_matches_macro warning in is_read_only_notes_invocation Co-Authored-By: Sasha Varlamov <sasha@sashavarlamov.com>
4 tasks
Contributor
devin-ai-integration
bot
deleted the
fix/async-mode-alias-post-commit-stats
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_gitparsed CLI args but never resolved git aliases before checking whether the command was"commit". When a user had e.g.alias.cm = commit,parsed.commandwas"cm"which didn't match theSome("commit")gate, so post-commit stats were silently skipped.resolve_alias_invocationcall in the async path (matching what the non-async wrapper path at line 190 already does).async_mode_post_commit_shows_stats_with_commit_alias) that configuresalias.cm = commit, commits AI content via the alias, and asserts the stats bar appears.Test plan
async_mode_post_commit_shows_stats_with_commit_aliaspassesasync_mode_post_commit_*tests still pass (6/6)🤖 Generated with Claude Code