Conversation
maybe_teardown_async_mode used daemon_is_up() which requires both the control AND trace sockets to be connectable. If the trace socket was down but the control socket was still up, the shutdown was silently skipped and the daemon process lingered. Use a direct control socket connectivity check instead, matching the behavior of `git-ai d shutdown`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maybe_teardown_async_modeuseddaemon_is_up()to decide whether to send a shutdown, but that helper requires both the control and trace sockets to be connectablegit-ai d shutdownwhich worked fine in the same scenarioTest plan
install-hooks, verify daemon is shut downinstall-hooksstill works normally with async mode enabled (daemon restart path unaffected)install-hooks --dry-runskips teardown as before🤖 Generated with Claude Code