Skip to content

Conversation

@maoshuai
Copy link
Contributor

@maoshuai maoshuai commented Sep 15, 2019

This seems to be a typo: the comment line should start with <!--
The user would have to manually correct the typo.

Context

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Update the Readme or any other documentation (including relevant Javadoc)
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B
  • Ensured that tests pass locally: mvn clean package

This seems to be a typo: the comment line should start with <!--
@TheSnoozer TheSnoozer merged commit 13dba97 into git-commit-id:master Sep 15, 2019
@TheSnoozer
Copy link
Collaborator

Nice catch!
Indeed that seems to be typo.

Thank you for your contribution and fixing this :-)

@TheSnoozer TheSnoozer added this to the 3.0.2 milestone Sep 15, 2019
@TheSnoozer TheSnoozer modified the milestones: 3.0.2, 4.0-modularized Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants