Skip to content

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jun 12, 2020

Context

While JUnit 5.5.1 (API) is being declared as a dependency, the actual tests are all using JUnit 4.x.

Contributor Checklist

  • Added relevant integration or unit tests to verify the changes
  • Ensured that tests pass locally: mvn clean package
  • Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

While JUnit 5.5.1 (API) is being declared as a dependency, the actual
tests are all using JUnit 4.x.
@TheSnoozer
Copy link
Collaborator

Thanks for the contribution. Looks good!

@TheSnoozer TheSnoozer merged commit e1f9366 into git-commit-id:master Jun 22, 2020
@TheSnoozer TheSnoozer added this to the 4.0.1 milestone Jun 22, 2020
@joschi joschi deleted the junit-cleanup branch June 23, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants