Link to download latest version is broken

[Cogito]

Looking at https://gitforwindows.org/ and clicking the link 'Download' directs me to the following URL which 404s:

https://github.com/git-for-windows/git/releases/download/v2.16.0.windows.2/Git-2.16.0-64-bit.exe

It appears as though this is meant to be:

https://github.com/git-for-windows/git/releases/download/v2.16.0.windows.2/Git-2.16.0.2-64-bit.exe

This is potentially related to #1433 but might be worth fixing in the meantime as it breaks the download functionality.

[shiftkey]

@Cogito can you re-test? I think this is working fine now.

[Cogito]

@shiftkey I am currently seeing the following, broken URL when clicking the link:

https://github.com/git-for-windows/git/releases/download/v2.16.0.windows.2/Git-2.16.0-64-bit.exe

I tried clearing my local cache/using a different browser/etc to try and make sure it wasn't just on my end.

[shiftkey]

@Cogito aha, I was testing it on a non-Windows OS. There's something in this code that isn't detecting the right version values.

[Cogito]

@shiftkey Yes, that code is assuming the release artefact will be called 2.16.0, not 2.16.0.2

That's why I think the root cause is #1433

The fix, I think, is to either

1. Publish release artefacts with the correct name
2. Change the 'version' on the gitforwindows.org page to be 2.16.0(2) rather than 2.16.0, until the correctly named artefact is released.

[Cogito]

The commit which broke the link is this one: git-for-windows/git-for-windows.github.io@ae93ce6

[dscho]

For the record, a PR would have been nice (I could have accepted that on my phone instead of cutting into vacation time and whipping out the laptop).

[shiftkey]

@dscho apologies for the interruption!

[dscho]

@shiftkey no apologies necessary. Does the link work now?

[shiftkey]

@dscho all good here!