-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
In git-for-windows/MSYS2-packages@ffd1140, I fixed the bug where bash.exe could not be code-signed (when ingested into GitHub Desktop), because the MSYS toolchain's strip.exe apparently modifies the .exe file's structure in a way that causes signtool.exe to fail.
In git-for-windows/MSYS2-packages@667799c, a change was made to the MSYS2 runtime build process where it is now stripped using the same tool (and likewise a couple of MSYS2 runtime's utilities such as cygwin-console-helper.exe), now causing the msys-2.0.dll file to be non-code-signable.
Reported by @aatala
We need to be careful here, though: The underlying reason why strip.exe is now used on MSYS2 runtime's binary files is that Cygwin is no longer using that funny, custom way to split out debug information into the .dbg file, and as a consequence the debug information is stored in the binary files, which increases their size by an order of magnitude. This bloat needs to be prevented while fixing the code-signing problems at the same time.