Skip to content

Bump html-to-md to v0.8.0 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Bump html-to-md to v0.8.0 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b435026
tests: stop mocking `html-to-md`
dscho Nov 20, 2022
dd45971
tests: validate `html-to-md` output
dscho Nov 20, 2022
203e277
Bump html-to-md to v0.8.0
dscho Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 51 additions & 2 deletions __tests__/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ const https = require('https')

jest.mock('@actions/core')
jest.mock('@actions/github')
jest.mock('html-to-md')

const core = require('@actions/core')
const { getOctokit, context } = require('@actions/github')
Expand Down Expand Up @@ -69,6 +68,56 @@ test('handles feed entries without titles', async () => {
owner: 'owner',
repo: 'repo',
title: new Date(date).toUTCString(),
body: '\n'
body: 'TBD\n'
})
})

test('html to markdown conversion', async () => {
const date = new Date().toISOString()
mockHTTPSGet.__RETURN__ = `<?xml version="1.0" encoding="UTF-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xmlns:media="http://search.yahoo.com/mrss/" xml:lang="en-US">
<id>tag:github.com,2008:/git-for-windows/rss-to-issues/commits/main</id>
<link type="text/html" rel="alternate" href="https://github.com/git-for-windows/rss-to-issues/commits/main"/>
<link type="application/atom+xml" rel="self" href="https://github.com/git-for-windows/rss-to-issues/commits/main.atom"/>
<title>Recent Commits to rss-to-issues:main</title>
<updated>${date}</updated>
<entry>
<id>tag:github.com,2008:Grit::Commit/394ee852b18c5e3bca536b585cbb95d32ce77057</id>
<link type="text/html" rel="alternate" href="https://github.com/git-for-windows/rss-to-issues/commit/394ee852b18c5e3bca536b585cbb95d32ce77057"/>
<title>
ci(release-tags): use newer versions of Actions
</title>
<updated>${date}</updated>
<media:thumbnail height="30" width="30" url="https://avatars.githubusercontent.com/u/127790?s=30&amp;v=4"/>
<author>
<name>dscho</name>
<uri>https://github.com/dscho</uri>
</author>
<content type="html">
&lt;pre style=&#39;white-space:pre-wrap;width:81ex&#39;&gt;ci(release-tags): use newer versions of Actions

This avoids warnings about node.js/set-output deprecations.

Signed-off-by: Johannes Schindelin &amp;lt;johannes.schindelin@gmx.de&amp;gt;&lt;/pre&gt;
</content>
</entry>
</feed>
`
octokit.issues.listForRepo.mockReturnValueOnce({ data: [] })
await run()

expect(octokit.issues.create).toBeCalledWith({
owner: 'owner',
repo: 'repo',
title: 'ci(release-tags): use newer versions of Actions',
body: `\`\`\`
ci(release-tags): use newer versions of Actions

This avoids warnings about node.js/set-output deprecations.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
\`\`\`

https://github.com/git-for-windows/rss-to-issues/commit/394ee852b18c5e3bca536b585cbb95d32ce77057`
})
})
2 changes: 1 addition & 1 deletion dist/index.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"dependencies": {
"@actions/core": "^1.10.0",
"@actions/github": "^4.0.0",
"html-to-md": "^0.5.3",
"html-to-md": "^0.8.0",
"rss-parser": "^3.12.0"
},
"devDependencies": {
Expand Down