Merged
Conversation
PR #216 머지로 도입된 MIXPANEL_PROJECT_TOKEN 환경변수를 Dockerfile과 GitHub Actions deploy 워크플로우에 추가한다. GitHub Secret 등록 후 release 브랜치 배포 시 Mixpanel 서버 사이드 이벤트 트래킹이 활성화된다.
devxb
reviewed
May 7, 2026
| "INTERNAL_AUTH_SECRET=${{ secrets.INTERNAL_AUTH_SECRET }}" | ||
| "LOGIN_SECRET=${{ secrets.LOGIN_SECRET }}" | ||
| "GITANIMALS_ADMIN_TOKEN=${{ secrets.GITANIMALS_ADMIN_TOKEN }}" | ||
| "MIXPANEL_PROJECT_TOKEN=${{ secrets.MIXPANEL_PROJECT_TOKEN }}" |
Member
There was a problem hiding this comment.
프로젝트 토큰만있는거 같은데 api 시크릿은 없어도 되는건가요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
#216 머지로 도입된
MIXPANEL_PROJECT_TOKEN환경변수를 배포 파이프라인에 주입하도록 설정한다.application.properties의mixpanel.project.token=\${MIXPANEL_PROJECT_TOKEN:}가 OS 환경변수에서 토큰을 읽어MixpanelConfiguration빈 생성에 사용된다. 토큰이 비어있으면NoOpEventLogger로 자동 fallback 되므로 Secret 등록 전에도 빌드/배포는 정상 동작한다.변경 사항
deploy/api/DockerfileARG MIXPANEL_PROJECT_TOKEN선언 추가ENV블록에mixpanel_project_token=\${MIXPANEL_PROJECT_TOKEN}매핑 추가.github/workflows/deploy.ymlbuild-args에MIXPANEL_PROJECT_TOKEN=\${{ secrets.MIXPANEL_PROJECT_TOKEN }}추가후속 작업 (수동)
MIXPANEL_PROJECT_TOKEN등록 (값: PR feat: Mixpanel 서버 사이드 이벤트 트래킹 추가 #216 본문 참조)참고
MixpanelEventLogger는MixpanelAPI()와MessageBuilder(token)만 사용하여 동일하게 확인됨.