Instruction nits #299
Merged
Instruction nits #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a shebang line to notice typos, bail on errors. Provide default values for variables. Add $prefix/bin to path.
Default packages for 14.04 are too old to build with these instructions. Add instructions for getting newer go. Add instructions for getting newer ruby and associated packages.
Also toss bison into the requirements for both CentOS and Ubuntu. Simplify installation of client and man pages to use "install -D"
Trivial cleanup.
Install prerequisites, then build client on CentOS 6/7, Debian 8, and Ubuntu 14.04. Also build docs on all but CentOS 6.
Contributor
Contributor
There was a problem hiding this comment.
#What if there line 13-15 you did instead
if git rev-parse; then
cd $(git rev-parse --show-toplevel)
else
cd /tmp
[ -d git-lfs ] || git clone https://github.com/github/git-lfs
cd git-lfs
fi
#That way it will use someone else's fork/branch for testing purposes? with out having to create a symlink to their repo from /tmp
andyneff
added a commit
to andyneff/git-lfs
that referenced
this pull request
May 17, 2015
andyneff
added a commit
to andyneff/git-lfs
that referenced
this pull request
May 30, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions for CentOS7, and some missing steps for Ubuntu 14.04.