Skip to content

Refactor some of the code in #404 #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
technoweenie merged 1 commit into from
Jul 7, 2015
Merged

Refactor some of the code in #404 #464

technoweenie merged 1 commit into from
Jul 7, 2015

Conversation

@technoweenie
Copy link
Contributor

@technoweenie technoweenie commented Jul 6, 2015

Some small changes to #404:

  1. Implemented @michael-k's suggestion in Improved SSH support: non-bare urls, custom ports, and GIT_SSH/plink #404 (diff). It's more clear where and how both isPlink and isTortoise are set.
  2. Removed any ssh stuff from NewEndpoint(). It now returns the correct Endpoint based on the url scheme. I really hope we don't try to support any other strings without a uri scheme ;)

/cc @sinbad

@sinbad
Copy link
Contributor

sinbad commented Jul 7, 2015

I'm happy with this.

technoweenie added a commit that referenced this pull request Jul 7, 2015
@technoweenie
Merge pull request #464 from github/ssh-refactor
a53565a 
Refactor some of the code in #404
@technoweenie technoweenie merged commit a53565a into master Jul 7, 2015
@technoweenie technoweenie deleted the ssh-refactor branch July 7, 2015 14:29
@technoweenie technoweenie self-assigned this Jul 7, 2015
This was referenced Jul 22, 2015
Merged
Closed
@technoweenie technoweenie removed their assignment Jul 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

review storage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@technoweenie @sinbad