Search packs as Git does #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git inteprets any files with .pack extensions as packs. For example, look at prepare_pack function in https://github.com/git/git/blob/master/packfile.c We should use same rules for Git LFS to prevent problems with arbitrary pack names.
bk2204
approved these changes
May 15, 2019
Member
bk2204
left a comment
bk2204
left a comment
There was a problem hiding this comment.
This looks fine. Thanks for the contribution!
Out of curiosity, is this just for tidiness, or did this cause you a problem somewhere?
Contributor
Author
|
Thank you for approval!
Yes, it caused problem with repository created by VFSForGit ( https://github.com/microsoft/VFSForGit ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git inteprets any files with .pack extensions as packs.
For example, look at prepare_pack function in https://github.com/git/git/blob/master/packfile.c
We should use same rules for Git LFS to prevent problems with arbitrary pack names.