Allow parsing very long lines in commit messages #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woopla
reviewed
Jan 30, 2020
woopla
reviewed
Jan 30, 2020
woopla
left a comment
woopla
left a comment
There was a problem hiding this comment.
LGTM, with the small typo to 'buffer' fixed.
It's technically possible for commit messages to contain arbitrary non-NUL bytes. Our commit message parser uses a 64 KiB buffer to read lines, and if lines are too long, it will fail. We've seen some cases where commit message lines are much longer due to historical accidents. Let's raise the maximum buffer size to 1 MiB to accommodate these situations. Let's also make it easier to track problems by returning a more helpful error message if the buffer size is exceeded.
chrisd8088
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's technically possible for commit messages to contain arbitrary non-NUL bytes. Our commit message parser uses a 64 KiB buffer to read lines, and if lines are too long, it will fail. We've seen some cases where commit message lines are much longer due to historical accidents.
Let's raise the maximum buffer size to 1 MiB to accommodate these situations. Let's also make it easier to track problems by returning a more helpful error message if the buffer size is exceeded.
Fixes git-lfs/git-lfs#4005
/cc @woopla as reporter