tree: don't use system stat constants #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On most Unix systems, the stat constants (S_IFMT and friends) that Git uses are the same: that is, the system values are the same ones that Git uses. However, on zOS, this isn't the case, and the system constants are different. Let's add a set of our constants that are used by Git to determine the type of an object that will be right on all platforms instead of using the system constants. Note that the tests already cover this case; they'll just now pass on additional systems.
chrisd8088
approved these changes
Jul 12, 2021
Member
chrisd8088
left a comment
chrisd8088
left a comment
There was a problem hiding this comment.
Seems sane and helpful, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On most Unix systems, the stat constants (S_IFMT and friends) that Git uses are the same: that is, the system values are the same ones that Git uses. However, on zOS, this isn't the case, and the system constants are different.
Let's add a set of our constants that are used by Git to determine the type of an object that will be right on all platforms instead of using the system constants. Note that the tests already cover this case; they'll just now pass on additional systems.
Fixes #24