Use constant format string #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "go vet -printf ./..." command, when run with Go 1.24 (and a matching Go version number in the "go.mod" file), now detects format strings that are not constants, as described in golang/go#60529. We have one such non-constant format string in the newToken() function of the "netrc" package, so we adjust it now to use a standard format string with a specifier verb. This issue was reported in: git-lfs/git-lfs#5968 (comment)
larsxschneider
approved these changes
Feb 18, 2025
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Feb 28, 2025
We recently updated our "netrc" Go package in PR git-lfs/go-netrc#3 with a small change to use a constant format string (as reported by Go 1.24's "go vet" command). We therefore now update the Go module list in this repository to reference the latest version of our git-lfs/go-netrc project, by running: go get github.com/git-lfs/go-netrc@latest We then also run the "go mod tidy" command to update the set of Go module hashes in the "go.sum" file.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Mar 5, 2025
We recently updated our "netrc" Go package in PR git-lfs/go-netrc#3 with a small change to use a constant format string (as reported by Go 1.24's "go vet" command). We therefore now update the Go module list in this repository to reference the latest version of our git-lfs/go-netrc project, by running: go get github.com/git-lfs/go-netrc@latest We then also run the "go mod tidy" command to update the set of Go module hashes in the "go.sum" file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
go vet -printf ./...command, when run with Go 1.24 (and a matching Go version number in thego.modfile), now detects format strings that are not constants, as described in golang/go#60529.We have one such non-constant format string in the
newToken()function of thenetrcpackage, so we adjust it now to use a standard format string with a specifier verb.This issue was reported as part of git-lfs/git-lfs#5968.