Fix data loss in rmtree when deletion fails#45
Merged
jovnc merged 5 commits intogit-mastery:mainfrom Mar 16, 2026
Merged
Conversation
desmondwong1215
force-pushed
the
fix/rmtree
branch
from
c3d000f to
ff2d546
Compare
desmondwong1215
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
desmondwong1215
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
desmondwong1215
temporarily deployed
to
e2e-test
GitHub Actions
Inactive
desmondwong1215
requested a deployment
to
e2e-test
GitHub Actions
Waiting
desmondwong1215
requested a deployment
to
e2e-test
GitHub Actions
Waiting
desmondwong1215
requested a deployment
to
e2e-test
GitHub Actions
Waiting
jovnc
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NUS-CS2103-AY2526-S2/forum#82
When
rmtree()fails (e.g., folder locked by another process),shutil.rmtreepartially deletes files before raising an exception. This causes permanent data loss - users lose theirprogress.jsondespite the operation failing. It also applies to other parts in the app that usermtree.Solution:
Implement backup-and-restore mechanism in
rmtree()):2a. If deletion fails: restore from backup automatically
2b. If restoration also fails: preserve the backup and show the user the path; the user can manually update the path before retrying.