Cap total decompressed size in tar and gem readers#7
Merged
Conversation
…exhaustion Wraps decompressed reads with `io.LimitReader` tracking cumulative bytes across all entries, rejecting archives that exceed 512 MiB decompressed. Applies to both `openTar` (per-entry and cumulative) and `openGem` (`data.tar.gz` read).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openTarbuffers every entry viaio.ReadAll(tr)with no size cap. A crafted archive with a high compression ratio (e.g. 199 KiB gzip -> 515 MiB decompressed) can exhaust process memory.Adds a 512 MiB cumulative limit on total decompressed bytes read across all tar entries, using
io.LimitReaderper entry. If the running total exceeds the cap,openTarreturnsErrDecompressLimit.Same treatment for
openGem, which doesio.ReadAll(tr)on the innerdata.tar.gzbefore handing it toopenTar.