Harden git clone argv and config file permissions#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two security fixes from a code review, both test-driven.
git cloneargument injection:repo.CloneURLcomes from the forge API and was passed directly toexec.CommandContext(ctx, "git", "clone", url). A malicious or compromised self-hosted instance could return aCloneURLlike--upload-pack=...which git would parse as an option rather than a URL. The fix extracts agitCloneArgshelper that inserts--before the URL to terminate option parsing. Applied to all three call sites inrepo create --clone,repo fork --clone, andrepo clone.Config file permissions:
os.WriteFile(path, data, 0600)only sets the mode when creating a new file. If~/.config/forge/configalready exists with looser permissions (manual creation, backup restore), writing a token viaSetDomainwould not tighten it. NowwriteINIcallsos.Chmodafter the write on non-Windows platforms.Both tests fail on
mainand pass after the fix.