Strip control characters from forge-sourced text#74
Merged
Conversation
Issue/PR titles, bodies, comments, labels, and other forge-sourced strings could contain ANSI escape sequences or OSC commands that manipulate the terminal when displayed. Adds output.Sanitize() to strip C0 control bytes (except tab and newline) and applies it to all display paths in the CLI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue/PR titles, bodies, comments, labels, release tags, and other forge-sourced strings could contain ANSI escape or OSC sequences that manipulate the terminal (spoofed output, title changes, clipboard writes on terminals with OSC 52 enabled).
Adds `output.Sanitize()` which strips C0 control bytes except tab and newline, and applies it to all display paths in the issue, PR, release, and repo CLI commands. JSON output is unaffected since `encoding/json` already escapes control bytes.