Configure goconst to ignore test files#34
Merged
Merged
Conversation
Test tables repeat version strings and package names across independent fixtures. Extracting them into shared constants would couple unrelated tests and make the assertions harder to read, so skip test files instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.golangci.ymlwithgoconst.ignore-tests: true.The 19 goconst warnings in
internal/npm/npm_test.goare version strings ("1.1.3","4.17.21") and package names ("@types/node","babel") that repeat because separate test cases assert against fixtures that happen to share packages. Pulling those into shared constants would couple unrelated tests and make each assertion harder to read at a glance.Using the goconst-level setting rather than a path exclusion because exclusions only filter where issues are reported, not which files contribute to the occurrence count, so a single production-code use of a string that appears twice more in tests would still be flagged.