Cap interpolated property string length to prevent amplification#2
Merged
Cap interpolated property string length to prevent amplification#2
Conversation
Self-referential properties like ${x}${x}${x} can amplify exponentially
across interpolation passes. Tracks net string growth within each pass
and stops substituting once the output would exceed 1 MiB.
andrew
force-pushed
the
fix/interpolation-amplification
branch
from
0c9578f to
b3e176c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-referential `` like `${x}${x}${x}` amplify exponentially across interpolation passes. Ten passes of a 5x self-reference would produce ~68 MiB from a tiny input.
Tracks net string growth during each `ReplaceAllStringFunc` pass and stops substituting once the output would exceed 1 MiB. Remaining `${...}` references stay unexpanded, same as unresolvable properties.