Reject absolute paths and symlinks in LocalFetcher parent traversal#3
Merged
Reject absolute paths and symlinks in LocalFetcher parent traversal#3
Conversation
LocalFetcher.walk follows <relativePath> from POM files to resolve parent chains. Absolute paths and symlinks could redirect reads outside the project tree. Now rejects absolute <relativePath> values and uses os.Lstat to skip symlinks at each step.
andrew
force-pushed
the
fix/local-path-traversal
branch
from
356c1cd to
3c97861
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`LocalFetcher.walk` follows `` declarations to resolve parent POM chains on the filesystem. A hostile `` set to an absolute path or pointing through a symlink could redirect reads outside the project tree.
Now rejects absolute `` values outright and uses `os.Lstat` to skip symlinks at each step of the walk, including when the path resolves to a directory and `pom.xml` is appended.