Fix cross-device link error when running in Docker with volumes#66
Merged
Fix cross-device link error when running in Docker with volumes#66
Conversation
`fileblob` creates temp files in `os.TempDir()` (`/tmp`) by default, then uses `os.Rename` to move them to the final path. When the storage directory is on a different filesystem (e.g. a Docker volume mount at `/data`), the rename fails with "invalid cross-device link". Set `no_tmp_dir=true` on file:// bucket URLs so fileblob creates temp files next to the final destination instead. Fixes #65
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileblobcreates temp files inos.TempDir()(/tmp) by default, then usesos.Renameto move them to the final path. When the storage directory is on a different filesystem (e.g. a Docker volume mount at/data), the rename fails with "invalid cross-device link".Sets
no_tmp_dir=trueonfile://bucket URLs so fileblob creates temp files next to the final destination instead. This is the documented solution from fileblob.Verified end-to-end with
docker compose up— the exact request from #65 (/composer/files/friendsofphp/php-cs-fixer/v3.94.2/...) now returns 200 with a volume mount.Fixes #65