Use git-pkgs/pom for Maven effective-POM resolution#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the local
fetchPOM/mergePOMsparent-walk withgithub.com/git-pkgs/pom, which additionally interpolates${...}properties, fills versions from<dependencyManagement>, and expands<scope>import</scope>BOMs.FetchDependenciesnow returns concrete versions (e.g.2.17.2instead of${jackson.version}).A
clientFetcheradapter wrapscore.Clientso all resolver HTTP still goes through the existing rate limiting, retries and circuit breaker. The resolver and aCachingFetcherare held onRegistryso repeated calls share parent/BOM fetches.FetchPackagemetadata (description, homepage, repository, licenses) now comes frompom.EffectivePOM, which does the same child-wins parent merge the old code did plus interpolation.FetchMaintainerskeeps a minimal local<developers>parse since the pom library doesn't carry that element.TestParentPOMResolutionis extended to assert${project.version}and a parent-defined${lib.version}viadependencyManagementboth resolve to concrete versions throughFetchDependencies.Net -39 lines.