Cap SPDX envelope unwrap depth to prevent quadratic re-parse#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseSPDXrecursively unwrapped{"sbom":...}and{"predicate":...}envelopes with no depth limit. Each level re-ranjson.Unmarshalon the full nested raw bytes, so a deeply nested input like{"sbom":{"sbom":{"sbom":...}}}produced quadratic parse work and could be used as a DoS vector.The recursion is now a bounded loop capped at
maxEnvelopeDepth = 3, which is enough for the real-world cases (GitHub dependency-graph wraps once undersbom, in-toto attestations wrap once underpredicate, and at most you'd see one inside the other). Anything deeper falls through toErrUnrecognized.Added
TestSPDXGitHubEnvelopeto confirm 1-2 levels ofsbomwrapping still parse correctly, andTestSPDXEnvelopeDepthLimitto confirm a 100-level nest is rejected immediately.