vers: HighestSatisfying helper for resolver-style picks#17
Merged
Conversation
The common shape of a package-manager resolver: fetch the list of
available versions from the registry, then pick the highest one that
still satisfies the user's manifest constraint. Callers all wrote
the same loop:
parsed, _ := vers.ParseNative(constraint, scheme)
var best string
for _, v := range versions {
if !parsed.Contains(v) {
continue
}
if best == "" || vers.CompareWithScheme(v, best, scheme) > 0 {
best = v
}
}
Surfaces it as one call:
best, err := vers.HighestSatisfying(versions, constraint, scheme)
Empty scheme parses constraint as a vers URI; non-empty scheme parses
it as native syntax (the same dispatch Satisfies uses). Versions that
fail to parse are skipped, not fatal — pulling messy registry data
through HighestSatisfying doesn't need a pre-filter pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `vers.HighestSatisfying(versions []string, constraint, scheme string) (string, error)`. Common shape of a package-manager resolver:
```go
parsed, _ := vers.ParseNative(constraint, scheme)
var best string
for _, v := range versions {
if !parsed.Contains(v) {
continue
}
if best == "" || vers.CompareWithScheme(v, best, scheme) > 0 {
best = v
}
}
```
Becomes:
```go
best, err := vers.HighestSatisfying(versions, constraint, scheme)
```
Behaviour
Tests
Five: npm constraint coverage (caret, tilde, range, intersection, no-match), order independence on the input slice, garbage-version skipping, vers-URI mode via empty scheme, and the empty-input case.