-
Notifications
You must be signed in to change notification settings - Fork 0
feat: demo GIFs, GIT_CAS_PASSPHRASE env var, backlog #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Support GIT_CAS_PASSPHRASE environment variable as an alternative to --vault-passphrase flag for safer passphrase handling (no CLI exposure). Add focused demo GIFs (hero, CLI, vault) embedded in README and GUIDE. Add backlog section to ROADMAP (named vaults, export, publish/mount, repo intelligence).
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe pull request adds documentation enhancements including inline images and expanded backlog items across GUIDE.md, README.md, and ROADMAP.md. Additionally, it refactors passphrase resolution in bin/git-cas.js by introducing a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@bin/git-cas.js`:
- Around line 47-52: The resolvePassphrase function uses the || operator so an
explicit empty string passed via --vault-passphrase will be treated as falsy and
the code will fall through to process.env.GIT_CAS_PASSPHRASE; change this to
preserve an explicit empty string or explicitly validate it: either use the
nullish coalescing operator (??) to prefer an empty string over env only when
opts.vaultPassphrase is defined, or add explicit validation in resolvePassphrase
to reject/handle an empty string (e.g., throw or return an error) so the
behavior is deterministic and not silently using the env var.
🧹 Nitpick comments (1)
bin/git-cas.js (1)
111-111: The--vault-passphraseflag still exposes passphrases inpsoutput and shell history.The PR objective is to avoid passphrase leaks via
ps/history by introducingGIT_CAS_PASSPHRASE. Consider adding a deprecation notice on the--vault-passphraseoption description (e.g.,"(deprecated: prefer GIT_CAS_PASSPHRASE env var)") to nudge users toward the safer path. Same applies to lines 168 and 205.
Use ?? instead of || so an explicit empty string from --vault-passphrase is not silently replaced by GIT_CAS_PASSPHRASE env var. Add hint text to all --vault-passphrase option descriptions nudging toward the env var.
|
@coderabbitai review pls |
|
✅ Actions performedReview triggered.
|
Summary
--vault-passphraseflag. Avoids exposing passphrases inpsoutput and shell history.git-cas-sandbox.Changes
bin/git-cas.jsresolvePassphrase()helper checks flag thenGIT_CAS_PASSPHRASEenv varREADME.mdGUIDE.mdROADMAP.mddocs/*.gifTest plan
GIT_CAS_PASSPHRASEworks:GIT_CAS_PASSPHRASE=x git cas vault initSummary by CodeRabbit
New Features
Documentation