Skip to content

Fix #319: Prove pre-push hook order by execution#583

Merged
flyingrobots merged 1 commit into
mainfrom
fix-319-pre-push-hook-behavior
Jun 4, 2026
Merged

Fix #319: Prove pre-push hook order by execution#583
flyingrobots merged 1 commit into
mainfrom
fix-319-pre-push-hook-behavior

Conversation

@flyingrobots

Copy link
Copy Markdown
Member

What changed

Replaced the pre-push hook header text assertion with an execution test that records the stubbed link-check and npm gate sequence.

Why

The old assertion proved a comment stayed in place. The new test proves the optional link check runs before the blocking npm gates.

Closes #319

Validation

  • npx vitest run test/unit/scripts/pre-push-hook.test.ts
  • npm run typecheck:test -- --pretty false

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 57 minutes and 12 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c1eb734-59c8-4dc9-a908-92269e4a048f

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and 549b45a.

📒 Files selected for processing (1)
  • test/unit/scripts/pre-push-hook.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-319-pre-push-hook-behavior

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots

flyingrobots commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@codex Code Lawyer Activity Summary

Issue Severity Source File Outcome
No actionable self-discovered issue found in this PR diff. None Self PR diff against origin/main No code changes made.

Validation:

Check Result
GraphQL review-thread audit 0 unresolved, non-outdated review threads
GraphQL review audit 0 Changes Requested reviews
git diff --check origin/main...origin/fix-319-pre-push-hook-behavior Pass
Added hard-ban token scan Hard-ban diff scan found no actionable additions.

@flyingrobots flyingrobots merged commit c2e22d8 into main Jun 4, 2026
17 checks passed
@flyingrobots flyingrobots deleted the fix-319-pre-push-hook-behavior branch June 4, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static text assertions in test/unit/scripts/pre-push-hook.test.ts

1 participant