Skip to content

Fix #378: Share git-cas store factory#589

Merged
flyingrobots merged 1 commit into
mainfrom
fix-378-shared-cas-factory
Jun 4, 2026
Merged

Fix #378: Share git-cas store factory#589
flyingrobots merged 1 commit into
mainfrom
fix-378-shared-cas-factory

Conversation

@flyingrobots

Copy link
Copy Markdown
Member

What changed

Added CasStoreFactory and routed CasBlobAdapter plus CasSeekCacheAdapter through the shared CDC git-cas construction recipe.

Why

Both adapters previously duplicated dynamic git-cas loading, CBOR codec construction, chunking setup, and logger observability wiring. The adapters still own their lazy caching behavior, but the construction recipe now has one owner.

Closes #378

Validation

  • npx vitest run test/unit/infrastructure/adapters/CasBlobAdapter.test.ts test/unit/infrastructure/adapters/CasSeekCacheAdapter.test.ts
  • npm run typecheck:src -- --pretty false
  • npx eslint src/infrastructure/adapters/CasStoreFactory.ts src/infrastructure/adapters/CasBlobAdapter.ts src/infrastructure/adapters/CasSeekCacheAdapter.ts

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 8 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dc3992ba-a075-4132-8d37-c5794058b9a1

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and 6b9c955.

📒 Files selected for processing (3)
  • src/infrastructure/adapters/CasBlobAdapter.ts
  • src/infrastructure/adapters/CasSeekCacheAdapter.ts
  • src/infrastructure/adapters/CasStoreFactory.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-378-shared-cas-factory

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots

flyingrobots commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@codex Code Lawyer Activity Summary

Issue Severity Source File Outcome
No actionable self-discovered issue found in this PR diff. None Self PR diff against origin/main No code changes made.

Validation:

Check Result
GraphQL review-thread audit 0 unresolved, non-outdated review threads
GraphQL review audit 0 Changes Requested reviews
git diff --check origin/main...origin/fix-378-shared-cas-factory Pass
Added hard-ban token scan Hard-ban diff scan surfaced adapter-local unknown fields in src/infrastructure/adapters/CasStoreFactory.ts; manually inspected and accepted as infrastructure-boundary typing that does not leak into domain or ports.

@flyingrobots flyingrobots merged commit 14ee28c into main Jun 4, 2026
17 checks passed
@flyingrobots flyingrobots deleted the fix-378-shared-cas-factory branch June 4, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CasBlobAdapter and CasSeekCacheAdapter duplicate _initCas()

1 participant