Skip to content

Fix #263: prove Deno close rejection behavior#591

Merged
flyingrobots merged 1 commit into
mainfrom
fix-263-deno-close-proof
Jun 3, 2026
Merged

Fix #263: prove Deno close rejection behavior#591
flyingrobots merged 1 commit into
mainfrom
fix-263-deno-close-proof

Conversation

@flyingrobots

Copy link
Copy Markdown
Member

Summary

  • replace the tautological Deno close rejection assertion with observable shutdown proof
  • keep the no-unhandled-rejection coverage while proving the server handle is cleared

Closes #263

Validation

  • npm exec vitest run test/unit/infrastructure/adapters/DenoHttpAdapter.test.ts
  • pre-push IRONCLAD gates 0-7 passed with WARP_QUICK_PUSH=1

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 30 minutes and 56 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5036457f-03b1-4f82-81f9-5cf0d3591a0c

📥 Commits

Reviewing files that changed from the base of the PR and between a21fb8b and 7b9d72b.

📒 Files selected for processing (1)
  • test/unit/infrastructure/adapters/DenoHttpAdapter.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-263-deno-close-proof

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

Release Preflight

  • package version: 18.0.0
  • prerelease: false
  • npm dist-tag on release: latest
  • npm pack dry-run: passed
  • jsr publish dry-run: passed

If you tag this commit as v18.0.0, release workflow will publish.

@flyingrobots

Copy link
Copy Markdown
Member Author

Code Lawyer Activity Summary

@codex please confirm this review posture.

Source Severity File Lines Finding Outcome
Self-review None test/unit/infrastructure/adapters/DenoHttpAdapter.test.ts L347-L351 No actionable issue found. The tautological assertion is replaced with observable shutdown and state-clear proof. No code change required.
PR threads None n/a n/a No unresolved review threads found by GraphQL review-thread query. No code change required.

Validation considered:

  • Existing PR CI check rollup is green.
  • Prior focused validation: npm exec vitest run test/unit/infrastructure/adapters/DenoHttpAdapter.test.ts.

@flyingrobots flyingrobots merged commit e3ef01b into main Jun 3, 2026
17 checks passed
@flyingrobots flyingrobots deleted the fix-263-deno-close-proof branch June 3, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DenoHttpAdapter test has literal expect(true).toBe(true) assertion

1 participant