Breaking Changes; Using Keythereum as keystore library #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spm32
reviewed
Nov 30, 2017
Member
spm32
left a comment
spm32
left a comment
There was a problem hiding this comment.
Looks good on my end, I think switching to Keythereum was the right call, hopefully someone finds a fix for bitcore-lib though.
Member
Author
|
The aforementioned bug is documented here: Consensys/eth-lightwallet#137 I have already started using the new keystore generator in the server alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge will replace a previous version of the library as the master version; removing the dual network WIP and replacing eth-lightwallet for keythereum as the keystore.
This library class is used as a base for extended classes needing access to signing functionality.
Reviews & comments welcome.